Change url to path at homework & Improve legibility#130
Open
academey wants to merge 2 commits intoDjangoGirls:masterfrom
academey:fix-ko-homework-readme
Open
Change url to path at homework & Improve legibility#130academey wants to merge 2 commits intoDjangoGirls:masterfrom academey:fix-ko-homework-readme
academey wants to merge 2 commits intoDjangoGirls:masterfrom
academey:fix-ko-homework-readme
Conversation
das-g
approved these changes
Aug 30, 2019
Member
|
👍 We should think about using the more explicit |
Member
|
As I don't understand corean, I've only reviewed the code change itself. Can someone from @DjangoGirls/ko-pr check whether they happen in the right context? |
Author
|
It doesn't be reviewed for a long time |
Member
|
Can someone from @DjangoGirls/ko-pr please hava a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I changed code like below at your ko/homework/README.md
*url(r'^drafts/$', views.post_draft_list, name='post_draft_list'), *
to
path('drafts/', views.post_draft_list, name='post_draft_list'),
And also improved legibility.
Thanks.