Skip to content

add an extra erosional base level that prevents ghost nodes to lower …#27

Open
EstherHeck wants to merge 2 commits intoDjneu:fastscape_updatefrom
EstherHeck:fastscape_update_PR_fix_material_loss
Open

add an extra erosional base level that prevents ghost nodes to lower …#27
EstherHeck wants to merge 2 commits intoDjneu:fastscape_updatefrom
EstherHeck:fastscape_update_PR_fix_material_loss

Conversation

@EstherHeck
Copy link

Here I add a functionality that prevents the loss of material through fastscape boundary flux when there is a mountain in the middle of the model.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • [X ] I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@EstherHeck
Copy link
Author

Hi @Djneu is that the branch that you have a PR into main for? Or should I make a PR to another branch?

@EstherHeck
Copy link
Author

o no, this is a mess. Appearantly I didnt base it on the latest version of you fastscape_update branch. Can you give me a hint, which branch I should take? Then I will do it again....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant