Fastscape update pr composition masks#28
Open
EstherHeck wants to merge 1 commit intoDjneu:fastscape_updatefrom
Open
Fastscape update pr composition masks#28EstherHeck wants to merge 1 commit intoDjneu:fastscape_updatefrom
EstherHeck wants to merge 1 commit intoDjneu:fastscape_updatefrom
Conversation
EstherHeck
force-pushed
the
fastscape_update_PR_composition_masks
branch
from
aa0eead to
63b7850
Compare
Djneu
reviewed
Jun 28, 2022
|
|
||
| // These are the compositional fields used to track deposition depth and | ||
| // sediment age of the sediments deposited by the FastScape plugin. | ||
| // ToDo: insert check that these fields are only set as a mask when fastscape is used? |
Owner
There was a problem hiding this comment.
It's probably fine without checking, I don't think there is any instance where someone would set these fields and want them included in the rheology calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added composition masks for sediment_age and deposition_depth, as Anne and me had the impression, that there were none so far.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: