Merged
Conversation
Before: 매 키 입력마다 Sink::try_new() → sink.set_volume() → sink.append() → sink.detach() After: play_on_stream() → source.amplify(volume).convert_samples::<f32>() → handle.play_raw() Sink의 내부 mixer 입력 핸들/Arc/Mutex 생성 오버헤드 제거 볼륨은 amplify()로 소스 레벨에서 선적용 디바이스 분리 시 NoDevice 복구 로직 유지 (source를 clone해서 재시도) 레이턴시 측정에서 sinkMs + appendMs → playMs 하나로 통합
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@claude pr 리뷰해줘