Open
Conversation
…er image can be marked as latest)
zsrdjan
commented
Jan 19, 2026
| /// <param name="mustangCliService">The Mustang CLI service for executing commands.</param> | ||
| /// <param name="uploadedFile">The file upload request with the PDF file to validate.</param> | ||
| /// <param name="loggerFactory">The logger factory for creating loggers.</param> | ||
| /// <param name="cancellationToken">The cancellation token for managing task cancellation.</param> |
Author
There was a problem hiding this comment.
param name was missing which caused a build warning.
| # Build and test | ||
| - name: Build solution | ||
| run: dotnet build ${{ env.SOLUTION_PATH }} --configuration Release --no-restore | ||
| run: dotnet build ${{ env.SOLUTION_PATH }} --configuration Release --no-restore /p:Version=${{ steps.is_release.outputs.version }} /p:TreatWarningsAsErrors=true |
Author
There was a problem hiding this comment.
TreatWarningsAsErrors added so that we fail the build in case of warnings
| files: | | ||
| publish/Docentric.EInvoice.Validator.RestServer-${{ steps.is_release.outputs.version }}.zip | ||
| publish/Docentric.EInvoice.Validator.RestServer-Self-Contained-${{ steps.is_release.outputs.version }}.zip | ||
| generate_release_notes: true |
Author
There was a problem hiding this comment.
This is how the automatically created release would look like:
https://github.com/Docentric/docentric-e-invoice-validator/releases/tag/v2016.1.0
| # Tag with version from Git tag (e.g., "v1.2.3" -> "1.2.3", "v1.2.3-preview.0" -> "1.2.3-preview.0") | ||
| type=semver,pattern={{version}} | ||
| # Tag "latest" only for stable releases (no prerelease suffix) | ||
| type=raw,value=latest,enable=${{ needs.build.outputs.is_stable == 'true' }} |
Author
There was a problem hiding this comment.
The latest tag will be set only for the "stable" releases. We don't want a preview version to be marked as latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build pipeline: release artifacts and Docker publish only on v* tags
This PR updates the CI/CD pipeline to properly handle release builds triggered by version tags with the following improvements:
Changes
1. Release Detection
v*(e.g.,v2026.1.0,v1.0.0-preview.0)-are stable)2. Build Configuration
/p:Versionparameter/p:TreatWarningsAsErrors=trueto enforce code qualityDirectory.Build.propsto use0.0.0as placeholder (overridden by Git tag in pipeline)AssemblyVersionandFileVersion(MSBuild auto-derives fromVersion)3. Build Artifacts
RestServer-2026.1.0-preview.0)4. GitHub Releases (Stable Releases Only)
5. Docker Images
latesttag only applied to stable releases (not preview/beta/rc versions)v*tags6. Permissions
contents: writepermission for creating GitHub releasespackages: writepermission for uploading artifacts