Skip to content

Add support for metric types histogram and summary, ability to reset, nop operation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hashworks wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add support for metric types histogram and summary, ability to reset, nop operation #19

hashworks wants to merge 7 commits into from

Conversation

@hashworks
Copy link

@hashworks hashworks commented Apr 30, 2022 •
edited
Loading

hashworks added 7 commits May 1, 2022 00:22
@hashworks
Add support for metric types histogram and summary
512b821 
* Resolves Docoyo#1
* Resolves Docoyo#2
@hashworks
Bump prom-client from 13.2.0 to 14.0.1
5fe05cc 
Closes Docoyo#17.
@hashworks
Add package-lock.json
a1e57c5 
https://nodejs.dev/learn/the-package-lock-json-file
> The package-lock.json file needs to be committed to your Git
  repository, so it can be fetched by other people, if the project is
  public or you have collaborators, or if you use Git as a source for
  deployments.
@hashworks
Drop unused var/const
1745e3e
@hashworks
Add ability to reset metrics, add nop operation
f4e9a92 
Resolves Docoyo#12.
@hashworks
Update prom-client to 14.1.0
5e33030
@hashworks
Don't reset counter if it exists already
e946ad2
@hashworks hashworks changed the title Add support for metric types histogram and summary Add support for metric types histogram and summary, ability to reset, nop operation Oct 8, 2022
@hashworks
Copy link
Author

hashworks commented Oct 8, 2022

@matterlobby Is this repo still maintained?

@hashworks hashworks mentioned this pull request Oct 8, 2022
Closed
@hashworks
Copy link
Author

hashworks commented Nov 12, 2023

Ping?

moonrockfamily
moonrockfamily reviewed May 8, 2024
View reviewed changes
Copy link

@moonrockfamily moonrockfamily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Thank you for this PR... Maybe publishing your own version is the way to go if the repo authors are too busy.

@pluk77
Copy link

pluk77 commented Sep 15, 2024

@hashworks have you ever published your code on NPM? I am looking for a prometheus exported with histograms and summaries.

@hashworks
Copy link
Author

hashworks commented Sep 15, 2024

No, and I'm not going to.

@pluk77
Copy link

pluk77 commented Sep 15, 2024

Do you perhaps have a working tgz file of your project which can be installed on node-red?

@hashworks
Copy link
Author

hashworks commented Sep 15, 2024

Just download https://github.com/hashworks/node-red-contrib-prometheus-exporter/archive/refs/heads/feature/HistogramSummary.zip and unzip to /var/lib/nodejs-node-red/.node-red/node_modules/node-red-contrib-prometheus-exporter (or wherever your node-red home is). You might want to install it using node-red first like you normally would, don't know if it does any special stuff to register things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moonrockfamily moonrockfamily moonrockfamily left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for metric type Summary Support for metric type Histogram In counter have a set value option

3 participants

@hashworks @pluk77 @moonrockfamily