feat(plane): update to v1.2.1 #627
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Plane project management template from v0.27.1 to v1.2.1, incorporating upstream changes from the official Plane release. The update includes a registry migration, dependency version updates, and new configuration requirements for the v1.2.1 release.
Key changes:
- Migrated Docker image registry from
makeplane/toartifacts.plane.so/makeplane/with version bump to v1.2.1 - Added new environment variables (
LIVE_SERVER_SECRET_KEY,LISTEN_HTTP_PORT,LISTEN_HTTPS_PORT) and proxy volumes required by the new version - Updated dependency versions (PostgreSQL 17→15.7, Valkey 7.2.5→7.2.11) and added restart policies across all services
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| meta.json | Updates version metadata from v0.27.1 to v1.2.1 |
| blueprints/plane/template.toml | Adds new environment variables, fixes RabbitMQ user variable interpolation, and updates domain/URL configurations for v1.2.1 |
| blueprints/plane/docker-compose.yml | Updates all image references to new registry and version, downgrades PostgreSQL, updates Valkey version, adds restart policies, and includes new proxy volumes |
blueprints/plane/template.toml
Outdated
| "RABBITMQ_VHOST=plane", | ||
| "API_BASE_URL=http://api:8000", | ||
| "DEBUG=0", | ||
| "CORS_ALLOWED_ORIGINS=https://${main_domain}", |
There was a problem hiding this comment.
The CORS_ALLOWED_ORIGINS environment variable is using HTTPS by default. According to the project guidelines, URL variables should use HTTP by default unless HTTPS is explicitly required by the application or when using a reverse proxy with SSL termination. Consider changing this to http://${main_domain} unless Plane specifically requires HTTPS for CORS origins.
blueprints/plane/docker-compose.yml
Outdated
| - .env | ||
|
|
||
| plane-minio: | ||
| image: minio/minio:latest |
There was a problem hiding this comment.
The MinIO image is using the latest tag, which violates the project convention. The latest tag can break templates when upstream images change unexpectedly. Pin this to a specific version (e.g., minio/minio:RELEASE.2024-12-13T22-19-12Z or another stable release) to ensure reproducible deployments.
blueprints/plane/template.toml
Outdated
| "MINIO_ENDPOINT_SSL=0" | ||
| "APP_DOMAIN=${main_domain}", | ||
| "APP_RELEASE=v1.2.1", | ||
| "WEB_URL=https://${main_domain}", |
There was a problem hiding this comment.
The WEB_URL environment variable is using HTTPS by default. According to the project guidelines, URL variables should use HTTP by default unless HTTPS is explicitly required by the application or when using a reverse proxy with SSL termination. Consider changing this to http://${main_domain} unless Plane specifically requires HTTPS for its web URL.
- Update image registry from makeplane/ to artifacts.plane.so/makeplane/ - Update default version from v0.27.1 to v1.2.1 - Update PostgreSQL from 17-alpine to 15.7-alpine - Update Valkey from 7.2.5-alpine to 7.2.11-alpine - Add LIVE_SERVER_SECRET_KEY environment variable (required for live service) - Add proxy volumes (proxy_config, proxy_data) - Add LISTEN_HTTP_PORT and LISTEN_HTTPS_PORT variables - Fix RabbitMQ user variable (was using literal string instead of variable) - Add restart policies for all services
Rasaboun
force-pushed
the
feat/plane-v1.2.1
branch
from
8eb29f0 to
7ad8913
Compare
- Change WEB_URL from https to http (per project guidelines) - Change CORS_ALLOWED_ORIGINS from https to http (per project guidelines) - Pin MinIO to specific version RELEASE.2025-09-07T16-13-09Z (avoid latest tag)
|
|
||
| plane-minio: | ||
| image: minio/minio:latest | ||
| image: minio/minio:RELEASE.2025-09-07T16-13-09Z |
There was a problem hiding this comment.
The MinIO image tag references a release date of September 7, 2025 (RELEASE.2025-09-07T16-13-09Z). Since MinIO uses actual release dates in their tags, this appears to be a valid future release tag format. However, using "latest" or future-dated tags can cause issues if the image doesn't exist yet or changes unexpectedly. According to the project conventions, versions should be pinned to specific, verified versions and the "latest" tag should never be used. Before committing, verify this specific MinIO release exists using "docker manifest inspect minio/minio:RELEASE.2025-09-07T16-13-09Z".
| image: artifacts.plane.so/makeplane/plane-frontend:${APP_RELEASE:-v1.2.1} | ||
| restart: unless-stopped |
There was a problem hiding this comment.
The previous version had explicit "command" directives for the web, space, admin, and live services (e.g., "node web/server.js web"). These have been removed in v1.2.1. While this may be intentional if the new images have updated ENTRYPOINT/CMD defaults, it's worth verifying that these services still start correctly without explicit commands. Consider testing the deployment to ensure all frontend services initialize properly.
1 participant
What is this PR about?
Update Plane template from v0.27.1 to v1.2.1
Changes:
makeplane/toartifacts.plane.so/makeplane/17-alpineto15.7-alpine7.2.5-alpineto7.2.11-alpineLIVE_SERVER_SECRET_KEYenvironment variable (required for live service)LISTEN_HTTP_PORTandLISTEN_HTTPS_PORTvariablesproxy_config,proxy_data)Checklist
Before submitting this PR, please make sure that:
Issues related (if applicable)
N/A
Screenshots or Videos
N/A - Template update based on Plane v1.2.1 Release