Add payment terms from society to invoice#14
Open
developmentOYR wants to merge 3 commits intoDoliCloud:developfrom
Open
Add payment terms from society to invoice#14developmentOYR wants to merge 3 commits intoDoliCloud:developfrom
developmentOYR wants to merge 3 commits intoDoliCloud:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating an invoice, payment terms and methods are not included by default. I have created and would like to use the variable CABINETMED_FORCE_PAYMENT_TERM_FROM_SOC to automatically extract these details from the settings defined in the third party profile in the generated invoice so that the customer does not have to do it manually each time.
We have also changed the translation variables PaymentTypeCarte to PaymentTypeCB since what is actually done is CB (Card) and the same with PaymentTypeOther since what is really done is VIR.
Finally we have created another global variable CABINETMED_SHOW_VIR_BANK to associate the bank with the payment.
The solution provided does precisely this.