Housekeeping: remove dead files, clean up config#71
Conversation
- Add firebase-debug.log to .gitignore - Remove cloudbuild.yaml (replaced by Kamal deployment) - Remove stale Cloud SQL env vars from deploy.yml (PRODUCTION_DB_NAME, PRODUCTION_DB_USER, CLOUD_SQL_CONNECTION_NAME, GOOGLE_SERVICE_NAME, GOOGLE_INSTANCE_NAME) - Clean up proxy comment in deploy.yml Closes #67
dyoung522
temporarily deployed
to
workflow-test
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mise.toml
Outdated
| @@ -0,0 +1,2 @@ | |||
| [tools] | |||
| ruby = "3" | |||
There was a problem hiding this comment.
mise.toml sets ruby = "3", which can resolve to different patch/minor versions than the repo’s pinned .ruby-version (3.4.8). This can lead to Gemfile.lock / native extension differences between contributors; consider pinning mise to the same exact Ruby version (or at least the same minor) as .ruby-version.
| ruby = "3" | |
| ruby = "3.4.8" |
| # Inject ENV variables into containers (secrets come from .kamal/secrets). | ||
| env: | ||
| clear: | ||
| PRODUCTION_DB_NAME: project_daedalus_production | ||
| PRODUCTION_DB_USER: daedalus | ||
| CLOUD_SQL_CONNECTION_NAME: projectdaedalus-fb09f:us-central1:project-daedalus | ||
| GOOGLE_PROJECT_ID: projectdaedalus-fb09f | ||
| STORAGE_BUCKET_NAME: project-daedalus-public | ||
| GOOGLE_REGION: us-central1 | ||
| GOOGLE_SERVICE_NAME: project-daedalus | ||
| GOOGLE_INSTANCE_NAME: project-daedalus | ||
| secret: | ||
| - RAILS_MASTER_KEY |
There was a problem hiding this comment.
This config removes the Cloud SQL-related env vars from Kamal, but the tracked .env file in the repo still defines PRODUCTION_DB_NAME, PRODUCTION_DB_USER, CLOUD_SQL_CONNECTION_NAME, GOOGLE_SERVICE_NAME, and GOOGLE_INSTANCE_NAME. To avoid confusion (and keep local/dev config aligned with deploy config), consider removing/deprecating them there as well or adding a short note about why they remain.
config/deploy.yml
Outdated
| # Remove this section when using multiple web servers and ensure you terminate SSL at your load balancer. | ||
| # | ||
| # Note: If using Cloudflare, set encryption mode in SSL/TLS setting to "Full" to enable CF-to-app encryption. | ||
| # Proxy configuration (SSL terminated externally) |
There was a problem hiding this comment.
The comment says SSL is terminated externally, but it doesn’t indicate what is responsible for termination (e.g., Cloudflare / load balancer) or what the expected incoming scheme/ports are. Adding that detail here would reduce the risk of misconfiguration (e.g., accidentally serving HTTP-only to the public internet).
| # Proxy configuration (SSL terminated externally) | |
| # Proxy configuration. | |
| # SSL/TLS is terminated by an external load balancer (HTTPS on :443 from clients), | |
| # which forwards plain HTTP on port 80 to these servers. This proxy then forwards | |
| # HTTP traffic to the application on app_port (3000). |
- Pin mise.toml Ruby to 3.4.8 to match .ruby-version - Comment out stale Cloud SQL/Cloud Run env vars in .env - Expand SSL termination comment in deploy.yml with details (Cloudflare terminates HTTPS, forwards HTTP to Kamal proxy)
dyoung522
temporarily deployed
to
workflow-test
GitHub Actions
Inactive
firebase-debug.logto.gitignorecloudbuild.yaml(replaced by Kamal deployment)deploy.ymlthat aren't used (app uses Firestore, not Cloud SQL):PRODUCTION_DB_NAME,PRODUCTION_DB_USER,CLOUD_SQL_CONNECTION_NAMEGOOGLE_SERVICE_NAME,GOOGLE_INSTANCE_NAMEGOOGLE_PROJECT_ID,STORAGE_BUCKET_NAME,GOOGLE_REGION(still used)230 specs passing, RuboCop clean.
Closes #67