Merged
Conversation
- Remove application_record.rb (never used, models use ActiveModel) - Remove SQLite database files (not used for data storage) - Clean up rails_helper.rb: remove AR migration checks, set use_active_record = false - Keep AR in the stack (ActiveStorage depends on it) but explicitly document it is not used for data Closes #65
dyoung522
temporarily deployed
to
workflow-test
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Removes leftover ActiveRecord scaffolding from a Rails app that uses Firestore for persistence, while keeping ActiveRecord available in the stack (e.g., for ActiveStorage) and disabling AR integration in the test suite.
Changes:
- Disable RSpec Rails’ ActiveRecord integration and remove migration/schema checks from
spec/rails_helper.rb. - Remove the unused
ApplicationRecordbase class.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/rails_helper.rb | Disables ActiveRecord support in RSpec and removes AR migration/schema maintenance logic. |
| app/models/application_record.rb | Deletes an unused AR base model class. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up unused AR artifacts while keeping AR in the stack (ActiveStorage depends on it).
application_record.rb(never used — models use ActiveModel + Firestore)rails_helper.rb: remove AR migration checks, setuse_active_record = false230 specs passing, RuboCop clean.
Closes #65