chore: Add docker and env-no-quotes mount formats

[ryan-blunden]

No description provided.

[nmanoogian]

Sorry for the delay on the review, @ryan-blunden, and thanks for putting this up! I actually just bumped into this missing mount format on a personal project the other day.

Everything looks good and works well in my testing. Just one small comment on the automated tests.

[nmanoogian]

check/copy-pasta: These look identical to the env tests above. I assume this is supposed to be testing the new formats?

diff --git a/pkg/controllers/secrets_test.go b/pkg/controllers/secrets_test.go
index 23ab1f6..bccb47c 100644
--- a/pkg/controllers/secrets_test.go
+++ b/pkg/controllers/secrets_test.go
@@ -82,15 +82,15 @@ func TestSecretsToBytes(t *testing.T) {
 		t.Errorf("Unable to convert secrets to byte array in %s format", format)
 	}
 
-	format = "env"
+	format = "env-no-quotes"
 	bytes, err = SecretsToBytes(secrets, format, "")
-	if !err.IsNil() || string(bytes) != strings.Join([]string{`S1="foo"`, `SECRET2="bar"`}, "\n") {
+	if !err.IsNil() || string(bytes) != strings.Join([]string{`S1=foo`, `SECRET2=bar`}, "\n") {
 		t.Errorf("Unable to convert secrets to byte array in %s format", format)
 	}
 
-	format = "env"
+	format = "docker"
 	bytes, err = SecretsToBytes(secrets, format, "")
-	if !err.IsNil() || string(bytes) != strings.Join([]string{`S1="foo"`, `SECRET2="bar"`}, "\n") {
+	if !err.IsNil() || string(bytes) != strings.Join([]string{`S1=foo`, `SECRET2=bar`}, "\n") {
 		t.Errorf("Unable to convert secrets to byte array in %s format", format)
 	}
 

(You can apply by copying the patch and doing pbpaste | git apply or pasting manually)

[nmanoogian]

We've gotten a few requests for this recently so I'll push the change back up on an internal branch (#481) and merge it. Thanks again for putting this up!