Fixed issue preventing fallback and metadata files from being saved in DOPPLER_CONFIG_DIR

[nmanoogian]

The DOPPLER_CONFIG_DIR was being appropriately used for reading/writing the configuration files but was not being used as the default for fallback and metadata files. This change hoists the default metadata and fallback directories to the configuration controller so it can be defined in the same spot as configuration.UserConfigFile.

[apazzolini]

Would these be better named as FallbackDir and MetadataDir since they're still used even if the user hasn't configured them? Or am I misunderstanding that part?

[nmanoogian]

Good question -- SetConfigDir is called in the init function with the default $HOME/.doppler directory, which is invoked automatically when the module loads. SetConfigDir already updates UserConfigDir and UserConfigFile so I'm mostly just following the existing naming pattern

cli/pkg/configuration/config.go

Lines 51 to 58 in f383368

	func init() {
	SetConfigDir(filepath.Join(utils.HomeDir(), ".doppler"))
	}
	func SetConfigDir(dir string) {
	UserConfigDir = dir
	UserConfigFile = filepath.Join(UserConfigDir, configFileName)
	}