Merged
Conversation
nmanoogian
previously approved these changes
May 27, 2025
Contributor
nmanoogian
left a comment
There was a problem hiding this comment.
Nice! Tested lightly and works as expected
This flag can be useful when using the CLI offline as network requests are not made when only using the fallback file.
94b7f94 to
157a031
Compare
nmanoogian
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag can be useful when using the CLI offline as network requests are not made when only using the fallback file. These changes apply to
doppler runanddoppler secrets download.The approach taken here seems cleaner to me than the one originally taken in #478. Plus, the error messages here are clearer as they mention the specific flag (
--fallback-onlyor--offline) that you utilized:Closes #465
Closes ENG-8748