Reconnect to Doppler after network failure when using --watch#492
Merged
apazzolini merged 4 commits intomasterfrom Jul 14, 2025
Merged
Reconnect to Doppler after network failure when using --watch#492apazzolini merged 4 commits intomasterfrom
apazzolini merged 4 commits intomasterfrom
Conversation
The code behind --watch (which is the only thing that triggers the performSSERequest function) does its own retrying.
emily-curry
previously approved these changes
Jul 10, 2025
Member
emily-curry
left a comment
emily-curry
left a comment
There was a problem hiding this comment.
Good stuff! I tested locally, tried to break it, but this feels pretty solid. I'm going to keep using this version locally for a while to see if I get any unexpected restarts, but this is good to merge now.
We no longer use the utils.Retry wrapper as we're unable to coordinate resetting of the sleep time when using it.
apazzolini
force-pushed
the
andre/watch-reconnect
branch
from
2697a09 to
d61e40e
Compare
Contributor
Author
|
@emily-curry Applied the generic change, note that the CLI repo requires re-review when anything changes. |
emily-curry
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if a client is using the --watch flag and loses connectivity to the Doppler API (either because they lost internet or the service they were connected to went down), the process started by doppler run would continue running but never be restarted.
This PR will now detect connectivity failures and handle reconnection. When reconnecting, the process will only be restarted if secrets have indeed changed; if no secrets were changed, the pre-existing process will continue running.
Closes ENG-8855