Open
Conversation
This reverts commit 951e9c5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR makes a couple of changes to synth power cells..
..and allows for synths to share power by using their power cord (if they have one) on another synth to, with their permission, charge off of their internal cell. Also, the
do_afterfor charging now shows on the synth charging rather than on the thing they're charging from, so that you can see it while you're charging off of another synth.Why It's Good For The Game
Normal synths probably shouldn't have to travel to multiple APCs to fully charge, and a larger synth having a larger cell makes sense, plus allows for gimmicks with the power sharing feature.
Testing Evidence
Tested with two clients, successfully got the confirmation popup, successfully charged off of the other android. Charged off an APC and added / removed oversized from myself with VV, noting that cell charge was as expected.
Changelog
🆑
add: Synthetics can now charge off of other synthetics
add: Synthetic power cells are now only 2 MJ; charge and discharge times are the same, however
add: Oversized synthetics now have 5 MJ power cells
/🆑