reverts shipchem overrides#893
Open
kittysmooch wants to merge 2 commits intoDopplerShift13:masterfrom
Open
Conversation
github-actions
bot
added
Sprites
Paxilmaniac
approved these changes
Feb 26, 2026
Member
Paxilmaniac
left a comment
Paxilmaniac
left a comment
There was a problem hiding this comment.
will require testmerging to ensure we didn't break something niche, looks good otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
reverts the shiptest chemistry related work in #80
the impact of this is fixing broken caps for a few reagent containers, removing the ability to cap beakers, returning beakers to their old storage values, and returning us to the beaker sprites inherited upstream from tg. some of the code uncommented is affected by the parity, but that means slightly less for them to worry about in the end really.
Why It's Good For The Game
the beaker cosmetic changes aren't necessarily higher quality than tg's sprites anymore, so we don't need them. the function of capping beakers is also less relevant now that jerrycans are available. finally, the fact that this feature was breaking bottle caps and other features elsewhere is whack as fuck.
Testing Evidence
currently some doppler exclusive waterbottle variations are lacking cap sprites, but this doesn't seem to affect gameplay and ill probably get that in the nevada pr shortly
Changelog
🆑
del: Removed shiptest beaker sprites and the ability to cap beakers.
fix: Fixed broken bottlecaps
🆑