adds a new engineering modsuit skin for those who want more glass in their life \\ fixes moonlight and orbiter modsuits sometimes not showing right on non-digitgrade humans#895
Open
Paxilmaniac wants to merge 8 commits intoDopplerShift13:masterfrom
Open
Conversation
github-actions
bot
added
Sprites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
adds a new modsuit skin to engineering modsuits and the CE advanced modsuit
styled in the theme of the hardworking shipbreakers of the universe
also fixes a bug that hurt the moonlight and orbiter modsuits that they would not appear correctly on some baseline humans
WHAT WAS BROKEN HOW AND HOW ITS FIXED:
tg has MOD_ICON_OVERRIDE and MOD_WORN_ICON_OVERRIDE that go with a skin in the section where all of a skin's parts are defined
due to how the unit test for checking modsuit parts works by default, it thinks that two different skins with different overrides, or where one has an override and the other doesn't, have different physical parts
this is fixed by just removing the icon override bits from the copied list that's checked in the unit test
Why It's Good For The Game
the bug fixed here would make your modsuit minus gloves invisible if you were a regular human, that's pretty bad
most other modsuits have a secondary skin of some sort except engineering suits, and who am I but generous to the people
Changelog
🆑
add: adds alternative modsuit skins for engineering and advanced modsuits
fix: fixes moonlight and orbiter modsuits becoming invisible on baseline humans
/:cl: