Conversation
geonnave
left a comment
geonnave
left a comment
There was a problem hiding this comment.
Thanks for this PR!
Could you add a very basic README to each new example folder explaining:
- what it does
- how to run it (and specific dependencies to install, if applicable)
|
I've added a README for the two examples and removed optional dependencies from pyproject.toml. The dependencies are now mentioned in each of the example's README |
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
I only have comestic comments. I'll try to test your PR later today.
dotbot/examples/sct.py
Outdated
| return True, i | ||
|
|
||
| return False, None | ||
|
No newline at end of file |
| sup_init_state: [ 1, 0 ] | ||
| sup_current_state: [ 1, 0 ] | ||
| sup_data_pos: [ 0, 11 ] | ||
| sup_data: [ 2, EV_updateInventory, 0, 1, EV__selectAndBroadcast, 0, 0, 1, EV__selectAndBroadcast, 0, 0, 1, EV_startTimer, 0, 1, 1, EV_timeout, 0, 2, 1, EV_selectAndBroadcast, 0, 0 ] No newline at end of file |
There was a problem hiding this comment.
| sup_data: [ 2, EV_updateInventory, 0, 1, EV__selectAndBroadcast, 0, 0, 1, EV__selectAndBroadcast, 0, 0, 1, EV_startTimer, 0, 1, 1, EV_timeout, 0, 2, 1, EV_selectAndBroadcast, 0, 0 ] | |
| sup_data: [ 2, EV_updateInventory, 0, 1, EV__selectAndBroadcast, 0, 0, 1, EV__selectAndBroadcast, 0, 0, 1, EV_startTimer, 0, 1, 1, EV_timeout, 0, 2, 1, EV_selectAndBroadcast, 0, 0 ] | |
|
Also the CI is complaining because of code formatting issues. Install and run black to solve the problems. |
|
Some of my comments above are still not addressed (the ones about the missing newline at end of file) |
|
Sorry for the missed lines. I've fixed the lines at the end for the remaining files |
3 participants
Adding two examples for the PyDotBot.
1. Minimum naming game (with and without motion): From a list of potential words, a swarm of DotBots runs a distributed algorithm to agree on a single word using local communication.
2. Work and charge: A swarm of DotBots alternate moving between a work region to perform work and a charge region to recharge.