device/bootloader: swarmit: add threshold for battery almost full level#123
Merged
aabadie merged 1 commit intoDotBots:mainfrom Feb 5, 2026
Merged
device/bootloader: swarmit: add threshold for battery almost full level#123aabadie merged 1 commit intoDotBots:mainfrom
aabadie merged 1 commit intoDotBots:mainfrom
Conversation
This helps testbed maintainer to know when a robot is fully charged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2102 2107 +5
=========================================
+ Hits 2102 2107 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geonnave
approved these changes
Feb 5, 2026
Contributor
geonnave
left a comment
geonnave
left a comment
There was a problem hiding this comment.
Thanks, LGTM and I agree with the 2.9 V value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps testbed maintainer to know when a robot is fully charged.
The battery full threshold is 2.9V (out of 3V). The value is open to discussion I guess.