update SA1518 to ignore empty (0 bytes) files #3927
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3927 +/- ##
==========================================
- Coverage 97.44% 97.33% -0.12%
==========================================
Files 926 931 +5
Lines 110283 110359 +76
Branches 3319 3322 +3
==========================================
- Hits 107467 107413 -54
- Misses 1847 1968 +121
- Partials 969 978 +9 🚀 New features to boost your workflow:
|
| var root = tree.GetRoot(cancellationToken); | ||
| var firstToken = root.GetFirstToken(includeZeroWidth: true); | ||
|
|
||
| return firstToken.IsKind(SyntaxKind.EndOfFileToken) && firstToken.FullSpan.Length == 0; |
There was a problem hiding this comment.
Tests for SA1518 can be improved by checking a file with a single space or something like that. firstToken.FullSpan.Length == 0 can currently be removed without any tests failing,
There was a problem hiding this comment.
I added two test cases with white space only "files".
Of those (depending on the setting) one would fail if the IsEmpty helper does not check if the token is empty.
| @@ -72,6 +72,12 @@ public override void Initialize(AnalysisContext context) | |||
|
|
|||
| private static void HandleSyntaxTree(SyntaxTreeAnalysisContext context, StyleCopSettings settings) | |||
| { | |||
| if (context.Tree.IsEmpty(context.CancellationToken)) | |||
There was a problem hiding this comment.
Considering how rare this is, I would have added this check as the last thing before reporting the diagnostic, to save a couple of clock cycles when no diagnostics are reported.
|
Looks good to me |
|
No idea why the tests are hanging. If someone with the access rights could trigger them again, please? |
|
I am tempted to push a non-change commit to trigger the pipeline again :) If any of the owners read this, please restart the pipeline. @bjornhellander can you approve, or does that require higher level of user rights? |
|
@DWIAltonaAnalytics, no I can't approve pull requests. @sharwell is the one you need. |
closes #3926