fix: correctly load real SharpHound collection files + add full --debug flag#12
Merged
DotNetRussell merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
…/etc) + add full --debug flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the loader so BloodBash now properly reads real SharpHound JSON collection files (the ones with top-level keys like "users", "computers", "groups", "domains", etc.).
Also added a new --debug flag that provides detailed verbose output during parsing, graph building, and analysis to make troubleshooting much easier.
Changes
Updated load_json_dir() to detect and use the correct collection key from SharpHound files
Added comprehensive --debug logging throughout loading, graph building, and analysis functions
Bumped version to 1.2.3
Minor cleanup and improved debug messages
Testing
Bash./BloodBash /path/to/SharpHound_Data/ --all --debug
The tool should now show:
"Using collection key 'users' (list of X items)"
Full object counts per file
Graph build stats
No more "Loaded 0 objects" error
Related
Closes the issue where BloodBash was unable to parse standard SharpHound output.