Enhance the memory driver #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods modified by this commit were `async` functions that awaited on a single `Future`. This commit changes them to a slightly more complicated signature, but returns the future instead of wrapping it with another one.
This version of the driver should work as described by the GitHub issue (DrMemCS#106). It needs analysis by clippy and many unit tests need to be written before it gets merged, however.
Recommended by clippy.
Recommended by clippy.
Recommended by clippy.
Recommended by clippy.
Closed
Rewrite the function to use a functional pipeline.
These tests make sure the Future interface works.
Previously, the `Devices` type implemented the `Future` trait directly. This would work in some cases but, in the case of a `select!` macro, it would fail because that macro drops all the futures that didn't resolve. Dropping the future would mean dropping the Devices type. In this version, the method `.get_next()` returns a `Future` that returns the next setting. Since the future isn't directly implemented by `Devices`, it can safely be "cancelled".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the changes from #106.