Fix start-up bug #152
Merged
Fix start-up bug #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a race condition when bringing up the logic blocks. The `tod` and `solar` tasks will exit when they have no clients. A handle to their broadcast channel is cloned and given to each logic block as it starts up. There is a small chance that, before the first logic block registers for these event, the `tod` or `solar` tasks will check how many clients they have and see that it's zero and exit. This commit uses `sync::Barrier` as a synchronization point so the `tod` and `solar` tasks check their number of clients after every logic block has initialized. A Barrier is also passed to each logic block so the for-loop won't proceed until the currently started logic block has registered for `tod` or `solar` events.
Hopefully this shortens compile and link times.
This code was in a `select!` block so the formatter doesn't touch it.
Now the "driver" spans exists for the life of the driver. The "init" span gets added during initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the logic block start-up bug.