-
Notifications
You must be signed in to change notification settings - Fork 182
add riscv build support #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Just so I understand: to enable riscv support this PR is essentially just updating the versions of some dependencies? |
yes, I have a risc-v board, and after updating deps, it works fine. |
| season_number | ||
| ) | ||
| .fetch_one(&mut *conn) | ||
| .fetch_one(conn.as_mut()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like these changes are mostly pedantic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to see if it can be done in another way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Excutor trait is no longer impl for Transaction.
Some option:
- I see another pull request Bump sqlx to 0.7.3 #597 which use extra level of deref like this
- .fetch_all(&mut *conn)
+ .fetch_all(&mut **conn)
- or we implement excutor back for Transaction.
which way do you prefer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason there isn't a implementation of Executor for Transaction in sqlx now is that it couldn't exist. The changelog of sqlx explicitly said that dereferencing the Transaction is the way to do it now, so not sure how option 2 is going to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason there isn't a implementation of
ExecutorforTransactionin sqlx now is that it couldn't exist. The changelog of sqlx explicitly said that dereferencing theTransactionis the way to do it now, so not sure how option 2 is going to work?
ha, seems so.
|
I built this fork and dim.db get locked after creating admin account |
old ring(tls related) do not support RISC-V, so update it to latest version.
also it will impact sqlx(upgrade from 0.5 to 0.7), 0.7 version sqlx remove Excutor trait in Transaction, so code need to be
modified for that.