feat: native macos menubar #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
reviewed
Jun 8, 2024
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "kira" | |||
| name = "Kira" | |||
Collaborator
There was a problem hiding this comment.
Package names are lowercase
IGI-111
reviewed
Jun 8, 2024
| let menu_bar = Menu::new(); | ||
|
|
||
| menu_bar.append_items(&[&app, &file]).unwrap(); | ||
| menu_bar.init_for_nsapp(); |
Collaborator
There was a problem hiding this comment.
we need a gtk window for the linux version of this, but in general, this entire thing should not be in a platform specific module if we're going to use it for multiple platform, this isn't a darwin menu, it's just the menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a native macos menu-bar and hides the slint one. This potentially could be reused across windows and Linux. On linux this would add gtk3 as a dep.