AdditionalResolutionDirectories for console app #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(!string.IsNullOrEmpty(setupData.AdditionalResolutionDirectories)) | ||
| { | ||
| var splits = setupData.AdditionalResolutionDirectories.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries); | ||
| if (!splits.Any()) return; |
Contributor
There was a problem hiding this comment.
It is better to throw an exception to let users know there is an error
Contributor
|
@sharadkjaiswal |
Contributor
|
@Randy-Ma @sharadkjaiswal What's the state of this PR? Can we resolve the conflicts and merge this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR provides support for AdditionalResolutionDirectories parameter for the console app so that users can provide list of additional path to resolve the test assembly. This option can be accessed using
add:parameter to the console app, this was already available on the GUI.This PR also makes use of AssemblyResolver class implementation to resolve the assembly path as using by the GUI application.
Reviewer