Bump cmake to 3.18 and bump EKAT version to 2.0#424
Merged
Conversation
bartgol
added
cmake
Contributor
There was a problem hiding this comment.
Pull request overview
Updates EKAT’s build requirements and internal versioning to align with newer CMake capabilities and reflect EKAT’s major-version evolution.
Changes:
- Bumped minimum required CMake version from 3.13 to 3.18 and removed related legacy conditionals.
- Updated EKAT version to
2.0.0. - Simplified TPL FetchContent usage by standardizing on
FetchContent_MakeAvailable, and modernized unit-test link directory handling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Raises minimum CMake version and updates EKAT version to 2.0.0. |
| cmake/tpls/EkatBuildYamlCpp.cmake | Removes legacy FetchContent path; always uses FetchContent_MakeAvailable. |
| cmake/tpls/EkatBuildSpdlog.cmake | Removes legacy FetchContent path; always uses FetchContent_MakeAvailable. |
| cmake/tpls/EkatBuildCatch2.cmake | Removes legacy FetchContent path; always uses FetchContent_MakeAvailable. |
| cmake/EkatUtils.cmake | Drops version-conditional Fortran compiler-id generator expression handling. |
| cmake/EkatCreateUnitTest.cmake | Replaces directory-wide link_directories with target-scoped target_link_directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeff-cohere
previously approved these changes
Apr 8, 2026
jgfouca
previously approved these changes
Apr 8, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jeff-cohere
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We were still requiring 3.13, which was released in 2018. E3SM already requires cmake 3.18 (released in 2020). Bumping to same version as our main customer seems reasonable. It also allows to remove some conditional cmake code that was meant to support older cmake versions.
Finally, since lots has changed since EKAT initial release (notably, breaking ekat into packages), it's past due that we bump the major version to 2.