Skip to content

Remove previously deprecated code#425

Merged
bartgol merged 2 commits intomasterfrom
bartgol/remove-deprecated-code
Apr 9, 2026
Merged

Remove previously deprecated code#425
bartgol merged 2 commits intomasterfrom
bartgol/remove-deprecated-code

Conversation

@bartgol
Copy link
Copy Markdown
Contributor

@bartgol bartgol commented Apr 8, 2026

Motivation

Some c++17 utilities were backported in ekat, to allow using them with C++14. They were deprecated a while ago, and eamxx stopped using them. Now that we bumped the major version is a good time to say bye bye.

Since we're dropping some deprecated interfaces, update the minor version too.

Closes #357

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes previously deprecated C++14 backports of C++17 utilities from EKAT’s core, along with the associated unit test, and updates build metadata accordingly.

Changes:

  • Delete deprecated backport headers (ekat_std_any.hpp, ekat_std_enable_shared_from_this.hpp) and stop installing them.
  • Remove the std_meta unit test and its CMake registration.
  • Bump EKAT minor version from 2.0.0 to 2.1.0.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/core/std_meta.cpp Removes the unit test that exercised the deprecated ekat::any implementation.
tests/core/CMakeLists.txt Stops building/running the removed std_meta test.
src/core/ekat_std_enable_shared_from_this.hpp Deletes deprecated ekat::enable_shared_from_this backport header.
src/core/ekat_std_any.hpp Deletes deprecated ekat::any backport header.
src/core/ekat_parameter_list.hpp Updates docs to reference std::any rather than ekat::any.
src/core/CMakeLists.txt Removes deleted headers from the installed/public header set.
CMakeLists.txt Updates EKAT version metadata (minor bump).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeff-cohere jeff-cohere self-requested a review April 9, 2026 16:27
@bartgol bartgol merged commit 81c550a into master Apr 9, 2026
8 checks passed
@bartgol bartgol deleted the bartgol/remove-deprecated-code branch April 9, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove back-port of C++17 features

3 participants