Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes previously deprecated C++14 backports of C++17 utilities from EKAT’s core, along with the associated unit test, and updates build metadata accordingly.
Changes:
- Delete deprecated backport headers (
ekat_std_any.hpp,ekat_std_enable_shared_from_this.hpp) and stop installing them. - Remove the
std_metaunit test and its CMake registration. - Bump EKAT minor version from
2.0.0to2.1.0.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/core/std_meta.cpp | Removes the unit test that exercised the deprecated ekat::any implementation. |
| tests/core/CMakeLists.txt | Stops building/running the removed std_meta test. |
| src/core/ekat_std_enable_shared_from_this.hpp | Deletes deprecated ekat::enable_shared_from_this backport header. |
| src/core/ekat_std_any.hpp | Deletes deprecated ekat::any backport header. |
| src/core/ekat_parameter_list.hpp | Updates docs to reference std::any rather than ekat::any. |
| src/core/CMakeLists.txt | Removes deleted headers from the installed/public header set. |
| CMakeLists.txt | Updates EKAT version metadata (minor bump). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeff-cohere
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some c++17 utilities were backported in ekat, to allow using them with C++14. They were deprecated a while ago, and eamxx stopped using them. Now that we bumped the major version is a good time to say bye bye.
Since we're dropping some deprecated interfaces, update the minor version too.
Closes #357