Adding support for Apple Silicon (without MPI)#428
Open
jeff-cohere wants to merge 2 commits intomasterfrom
Open
Adding support for Apple Silicon (without MPI)#428jeff-cohere wants to merge 2 commits intomasterfrom
jeff-cohere wants to merge 2 commits intomasterfrom
Conversation
jeff-cohere
commented
Apr 9, 2026
|
|
||
| #else | ||
|
|
||
| // Drop-in replacement of some useful GNU utils (needed on Apple platforms) |
Contributor
Author
There was a problem hiding this comment.
It occurs to me that this logic was intended for Intel Macs, which are pretty old at this point. We could delete this code block if it's not used for anything else.
bartgol
approved these changes
Apr 11, 2026
Contributor
bartgol
left a comment
bartgol
left a comment
There was a problem hiding this comment.
@jeff-cohere If supporting APPLE devices is important, we can add a job of the cpu-gcc workflow that runs on macos-latest...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stubs out floating point environment logic for Apple Silicon (whose floating point environment is different and complicated and possibly something to be studied in the distant future).
Apple products are supported only without MPI, because some hwloc-related features aren't supported on Apple silicon, and this can produce failures if special steps are not taken. We can follow this up with a PR that adds support for MPI on Macs if there is interest.
Accordingly, I've also disabled the EKAT comm unit test when MPI is disabled.
Motivation
Some folks like to develop on their laptops. This allows EKAT to be built in a restricted way to support this kind of development. At the very least, mam4xx developers will be able to work on mam4xx's standalone configuration on Macs.
Testing
The PR doesn't change any testing logic, aside from disabling an MPI-related test when MPI is disabled.