Skip to content

Fixes marbl column fields initialization #4

Open
njeffery wants to merge 2 commits intoE3SMv2from
njeffery/update-param-spCaCO3
Open

Fixes marbl column fields initialization #4
njeffery wants to merge 2 commits intoE3SMv2from
njeffery/update-param-spCaCO3

Conversation

@njeffery
Copy link
Copy Markdown

Some column fields are never initialized in MARBL and only defined in active cells. This causes a crash when debug_build is true due to NaNs. This fix passes a debug compile = true.

See Issue E3SM-Project/E3SM#7990

The intialization is BFB after 2-years - see https://e3sm.atlassian.net/wiki/spaces/HESF/pages/5866095251/01152026.v3.LR.GMPAS.marbl.compy

I've also changed a bgc parameter that's hardcoded. E3SMv3 HES is using parm_f_prod_sp_CaCO3 = 0.049_r8 instead of 0.07 to improve surface alkalinity. The change has been tested in several 100-year simulations including our emissions runs.
For example:
https://e3sm.atlassian.net/wiki/spaces/HESF/pages/5184651334/20250306.v3.LR.HES-CBGC.20tr.Emissions01

nonBFB in BGC runs. BFB for all others.

@njeffery njeffery added the bug Something isn't working label Jan 27, 2026
@njeffery
Copy link
Copy Markdown
Author

@jonbob : I'm not sure if this is the correct branch for merging. Should we create an E3SMv3?

@njeffery
Copy link
Copy Markdown
Author

@maltrud and @katsmith133 : This is the version I've tested to make sure it's bfb. I can also pull the code changes into a new initialization subroutine like we discussed. Let me know if I should proceed with that option.

@jonbob
Copy link
Copy Markdown

jonbob commented Jan 27, 2026

@njeffery -- I think this is right. We do this first in order to get a new hash for marbl, and then make an E3SM PR to move to the new hash

@njeffery
Copy link
Copy Markdown
Author

@katsmith133 and @maltrud : Just a reminder to take a look at this when you get a chance. Thanks!

@njeffery njeffery marked this pull request as ready for review March 18, 2026 14:23
Copy link
Copy Markdown

@katsmith133 katsmith133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by inspection, nice work @njeffery! I just had one question, but I don't think it affects my approval.

@njeffery
Copy link
Copy Markdown
Author

njeffery commented Apr 9, 2026

@jonbob : I don't really want to change MARBL E3SMv2. Could we call this E3SMv3?

@jonbob
Copy link
Copy Markdown

jonbob commented Apr 9, 2026

I think that makes sense

@njeffery njeffery removed the request for review from maltrud April 9, 2026 15:21
@njeffery
Copy link
Copy Markdown
Author

njeffery commented Apr 9, 2026

@katsmith133 : Are you good with the kmt logic?

@katsmith133
Copy link
Copy Markdown

@katsmith133 : Are you good with the kmt logic?

Yes, I am good with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants