Conversation
changed parm_f_prod_sp_CaCO3 from 0.07 to 0.049
|
@jonbob : I'm not sure if this is the correct branch for merging. Should we create an E3SMv3? |
|
@maltrud and @katsmith133 : This is the version I've tested to make sure it's bfb. I can also pull the code changes into a new initialization subroutine like we discussed. Let me know if I should proceed with that option. |
|
@njeffery -- I think this is right. We do this first in order to get a new hash for marbl, and then make an E3SM PR to move to the new hash |
|
@katsmith133 and @maltrud : Just a reminder to take a look at this when you get a chance. Thanks! |
katsmith133
left a comment
There was a problem hiding this comment.
Approved by inspection, nice work @njeffery! I just had one question, but I don't think it affects my approval.
|
@jonbob : I don't really want to change MARBL E3SMv2. Could we call this E3SMv3? |
|
I think that makes sense |
|
@katsmith133 : Are you good with the kmt logic? |
Yes, I am good with this! |
Some column fields are never initialized in MARBL and only defined in active cells. This causes a crash when debug_build is true due to NaNs. This fix passes a debug compile = true.
See Issue E3SM-Project/E3SM#7990
The intialization is BFB after 2-years - see https://e3sm.atlassian.net/wiki/spaces/HESF/pages/5866095251/01152026.v3.LR.GMPAS.marbl.compy
I've also changed a bgc parameter that's hardcoded. E3SMv3 HES is using parm_f_prod_sp_CaCO3 = 0.049_r8 instead of 0.07 to improve surface alkalinity. The change has been tested in several 100-year simulations including our emissions runs.
For example:
https://e3sm.atlassian.net/wiki/spaces/HESF/pages/5184651334/20250306.v3.LR.HES-CBGC.20tr.Emissions01
nonBFB in BGC runs. BFB for all others.