Add the Eos function to convert CT into PotT#366
Open
alicebarthel wants to merge 5 commits intoE3SM-Project:developfrom
Open
Add the Eos function to convert CT into PotT#366alicebarthel wants to merge 5 commits intoE3SM-Project:developfrom
alicebarthel wants to merge 5 commits intoE3SM-Project:developfrom
Conversation
47021dd to
8aba3e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR to introduce the EOS helper function (CT-->PT, i.e.
calcPtFromCt) (and thecalcCtFromPt,calcGibbsDerivPt0Pt0helper functions that it requires).These conversion functions are not currently plugged into anything but will be required in the coupling steps later.
Since this is an inner helper function, I only added a line in the devGuide to inform of the capability.
A couple of Ctests simply compare a single-cell value between the GSW-C module and our implementation of
calcPtFromCtandcalcCtFromPt.I also made modifications to PhysicalConstants to introduce variables for future coupling, namely
Cp0Sw,SS0,Psu2GpkgandSfac, which are not currently used anywhere.Checklist
has passed, using the Polaris
e3sm_submodules/Omegabaseline