Skip to content

Exchange state halos at every Runge-Kutta stage #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwarusz wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Exchange state halos at every Runge-Kutta stage #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/omega/src/timeStepping/RungeKutta2Stepper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ void RungeKutta2Stepper::doStep(OceanState *State, // model state
updateTracersByTend(NextTracerArray, CurTracerArray, State, NextLevel, State,
CurLevel, 0.5 * TimeStep);

// We need to exchange tracer halos at every stage for high-order advection
State->exchangeHalo(NextLevel);
MeshHalo->exchangeFullArrayHalo(NextTracerArray, OnCell);

// R_q^{n+0.5} = RHS_q(u^{n+0.5}, h^{n+0.5}, phi^{n+0.5}, t^{n+0.5})
Expand Down
7 changes: 1 addition & 6 deletions components/omega/src/timeStepping/RungeKutta4Stepper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,7 @@ void RungeKutta4Stepper::doStep(OceanState *State, // model state

Pacer::timingBarrier("RK4:haloExchProvisBarrier", 3, Comm);
Pacer::start("RK4:haloExchProvis", 3);
// TODO(mwarusz) this depends on halo width actually
if (Stage == 2) {
ProvisState->exchangeHalo(CurLevel);
}
// We need to exchange tracer halos at every stage for high-order
// advection
ProvisState->exchangeHalo(CurLevel);
MeshHalo->exchangeFullArrayHalo(ProvisTracers, OnCell);
Pacer::stop("RK4:haloExchProvis", 3);

Expand Down
Loading