Refactor hierarchical parallelism wrappers#381
Open
mwarusz wants to merge 25 commits intoE3SM-Project:developfrom
Open
Refactor hierarchical parallelism wrappers#381mwarusz wants to merge 25 commits intoE3SM-Project:developfrom
mwarusz wants to merge 25 commits intoE3SM-Project:developfrom
Conversation
Member
Author
TestingCTest unit tests
Polaris
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: mwarusz <5665111+mwarusz@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6c3406a to
62496e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors Omega wrappers of Kokkos hierarchical parallelism. Specifically, it:
Range:vertRange(KMin, KMax)with manual offsetting of loop indices.LaunchConfigandTeamScratch. For exampleintparameter.TeamScratch<Real, int>(NScratchReal, NScratchInt).parallelReduceOuter.LaunchConfigserves as a general customization point for outer loops. For example, you can also request a different team size.OmegaKokkos.hinto their own header files:OmegaKokkosFlatPar.hfor flat parallelism andOmegaKokkosHiPar.hfor hierarchical parallelism.OmegaKokkos.hnow mostly contains general purpose Kokkos utilities.parallelSearchInnerfor searching an index range in parallel at the inner level of hierarchical parallelism.Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build