Adds reading of omega HorzMesh from mesh iostream #382
Open
philipwjones wants to merge 2 commits intoE3SM-Project:developfrom
Open
Adds reading of omega HorzMesh from mesh iostream #382philipwjones wants to merge 2 commits intoE3SM-Project:developfrom
philipwjones wants to merge 2 commits intoE3SM-Project:developfrom
Conversation
Uses an input IOStream to read the input horizontal mesh variables. The same filename is used by Decomp. If the Decomp optional argument for a mesh file is supplied, that value overrides the mesh stream filename. All physical mesh fields are defined for IO and are added to a field group HorzMeshIn. Some cleanup of the HorzMesh test driver is included to reduce test output and conform to omega code conventions. User and developer docs have been updated with these changes.
updated HorzMesh interfaces
Author
|
Passes ctests on Perlmutter (CPU) |
|
Thanks @philipwjones! I'll take a look ASAP. |
6 tasks
|
I'm working on the Polaris side of supporting these changes in E3SM-Project/polaris#527. That's going to need some fixes in Polaris for the horizontal pressure gradient before it can be tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses an input IOStream to read the input horizontal mesh variables. The same filename is used by Decomp. If the Decomp optional argument for a mesh file is supplied (eg in some unit test drivers), that value overrides the mesh stream filename. All physical mesh fields are defined for IO and are added to a field group HorzMeshIn. Some cleanup of the HorzMesh test driver is included to reduce test output and conform to omega code conventions. User and developer docs have been updated with these changes.
Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR buildFixes #311