Skip to content

Add state validation checks for NaNs and OOBounds#383

Open
amametjanov wants to merge 1 commit intoE3SM-Project:developfrom
amametjanov:omega/add-state-validation
Open

Add state validation checks for NaNs and OOBounds#383
amametjanov wants to merge 1 commit intoE3SM-Project:developfrom
amametjanov:omega/add-state-validation

Conversation

@amametjanov
Copy link
Copy Markdown
Member

@amametjanov amametjanov commented Apr 8, 2026

Initial validateOceanState function to check for NaNs and bounds

  • LayerThickness: 1e-10 to 1000
  • KineticEnergyCell: up to 10 (don't need a lower bound)
  • Temperature: -10 to 50
  • Salinity: -2 to 60

Checklist

  • Documentation:
  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests
      • Document testing used to verify the changes including any tests that are added/modified/impacted.
      • Performance related PRs: Please include a relevant PACE experiment link documenting performance before and after.
    • New tests:
      • CTest unit tests for new features have been added per the approved design.
      • Polaris tests for new features have been added per the approved design (and included in a test suite)
  • Stealth Features
    • If any stealth features are included in the PR, please confirm that they have been documented.

@xylar
Copy link
Copy Markdown

xylar commented Apr 8, 2026

KineticEnergyCell: up to 10 (don't need a lower bound)

Lower bound is zero.

Initial validateOceanState function to check for NaNs and bounds
- LayerThickness: 1e-10 to 1000
- KineticEnergyCell: 0 to 10
- Temperature: -10 to 50
- Salinity: -2 to 60
@amametjanov amametjanov force-pushed the omega/add-state-validation branch from a5af34c to 8818025 Compare April 8, 2026 07:47
@amametjanov
Copy link
Copy Markdown
Member Author

Thanks. Updated and linted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants