Skip to content

Remove configs/Default.yml#385

Open
xylar wants to merge 1 commit intoE3SM-Project:developfrom
xylar:omega/remove-extra-config-defaults
Open

Remove configs/Default.yml#385
xylar wants to merge 1 commit intoE3SM-Project:developfrom
xylar:omega/remove-extra-config-defaults

Conversation

@xylar
Copy link
Copy Markdown

@xylar xylar commented Apr 12, 2026

This should not exist and the config options for omega should only come from componets/omega/configs/Default.yml

Checklist

  • Linting
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests

Fixes #384

This should not exist and the config options for omega should only
come from `componets/omega/configs/Default.yml`
@xylar xylar requested a review from alicebarthel April 12, 2026 10:28
@xylar
Copy link
Copy Markdown
Author

xylar commented Apr 12, 2026

@alicebarthel, could you confirm that this file was added in #222 by mistake and should be removed?

@xylar xylar added the bug Something isn't working label Apr 12, 2026
@xylar
Copy link
Copy Markdown
Author

xylar commented Apr 12, 2026

Testing

To do this testing, I did a local rebase of this branch onto the Omega submodule in Polaris. This is because Polaris is not yet ready for the changes from #353, which was recently merged here.

CTest unit tests:

  • Machine: pm-cpu
  • Compiler: gnu
  • Build type: Release
  • Result: All tests passed
  • Log: /pscratch/sd/x/xylar/polaris_1.0/pm-cpu/test_20260412/omega-pr-remove-extra-config2/build/ctests.log

Polaris omega_pr suite

  • Baseline workdir: /pscratch/sd/x/xylar/polaris_1.0/pm-cpu/test_20260411/omega-pr-move-cpptrace
  • Baseline build: /pscratch/sd/x/xylar/polaris_1.0/pm-cpu/test_20260411/omega-pr-move-cpptrace/build
  • PR build: /pscratch/sd/x/xylar/polaris_1.0/pm-cpu/test_20260412/omega-pr-remove-extra-config2/build
  • PR workdir: /pscratch/sd/x/xylar/polaris_1.0/pm-cpu/test_20260412/omega-pr-remove-extra-config2
  • Machine: pm-cpu
  • Compiler: gnu
  • Build type: Release
  • Log: /pscratch/sd/x/xylar/polaris_1.0/pm-cpu/test_20260412/omega-pr-remove-extra-config2/polaris_omega_pr.o51452170
  • Result: All tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File configs/Default.yml should be removed

1 participant