Fix mapping MPAS-O to Omega config options#451
Conversation
The mapping now works given MPAS-O config options that map to Omega config options with non-unique names and nested section names.
TestingThis worked for me in combination with #435 (after commenting out a few model config options that aren't supported on the Omega Both convective and shear mixing are disabled, as desired. |
|
@xylar Am I understanding correctly that in the MPAS-O to Omega mapping, we don't actually use MPAS-O section names, keeping it None, simply because we don't need to since MPAS-O config option names are unique? |
Yes, exactly. And not editing all the locations where we currently set config options without providing an MPAS-O section will save a lot of tedium. We will eventually have to address this when we switch to Omega --> MPAS-O mapping instead of the reverse, but we can punt on that for now. |
cbegeman
left a comment
There was a problem hiding this comment.
This fix resolves the issue for me as well. Thanks for your help with this!
|
Great! Thanks for the review, @cbegeman! |
The mapping now works given MPAS-O config options that map to Omega config options with non-unique names and nested section names.
Checklist
Testingcomment in the PR documents testing used to verify the changesFixes #450