Skip to content

Fix mapping MPAS-O to Omega config options#451

Merged
xylar merged 1 commit intoE3SM-Project:mainfrom
xylar:fix-2-level-config
Jan 27, 2026
Merged

Fix mapping MPAS-O to Omega config options#451
xylar merged 1 commit intoE3SM-Project:mainfrom
xylar:fix-2-level-config

Conversation

@xylar
Copy link
Copy Markdown
Collaborator

@xylar xylar commented Jan 23, 2026

The mapping now works given MPAS-O config options that map to Omega config options with non-unique names and nested section names.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

Fixes #450

The mapping now works given MPAS-O config options that
map to Omega config options with non-unique names and nested
section names.
@xylar xylar requested a review from cbegeman January 23, 2026 16:10
@xylar xylar self-assigned this Jan 23, 2026
@xylar xylar added bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to the ocean component labels Jan 23, 2026
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jan 23, 2026

Testing

This worked for me in combination with #435 (after commenting out a few model config options that aren't supported on the Omega develop branch). In particular, in ocean/single_column/vmix_stable/forward_constant/omega.yml, I see:

  VertMix:
    Background:
      Diffusivity: 1.0e-5
      Viscosity: 1.0e-4
    Convective:
      Enable: false
      Diffusivity: 1.0
      TriggerBVF: 0.0
    Shear:
      Enable: false
      NuZero: 0.005
      Alpha: 5.0
      Exponent: 2.0

Both convective and shear mixing are disabled, as desired.

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jan 23, 2026

@cbegeman, could you cherry-pick this commit and confirm that it fixes #450 for you as well?

@cbegeman
Copy link
Copy Markdown
Collaborator

@xylar Am I understanding correctly that in the MPAS-O to Omega mapping, we don't actually use MPAS-O section names, keeping it None, simply because we don't need to since MPAS-O config option names are unique?

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jan 26, 2026

@xylar Am I understanding correctly that in the MPAS-O to Omega mapping, we don't actually use MPAS-O section names, keeping it None, simply because we don't need to since MPAS-O config option names are unique?

Yes, exactly. And not editing all the locations where we currently set config options without providing an MPAS-O section will save a lot of tedium. We will eventually have to address this when we switch to Omega --> MPAS-O mapping instead of the reverse, but we can punt on that for now.

Copy link
Copy Markdown
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix resolves the issue for me as well. Thanks for your help with this!

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jan 27, 2026

Great! Thanks for the review, @cbegeman!

@xylar xylar merged commit bd87bf2 into E3SM-Project:main Jan 27, 2026
7 checks passed
@xylar xylar deleted the fix-2-level-config branch January 27, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis ocean Related to the ocean component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config mapping issue with 2-level config options

2 participants