Skip to content

Add utility for zMid#453

Merged
cbegeman merged 5 commits intoE3SM-Project:mainfrom
cbegeman:add-zmid-utility
Jan 30, 2026
Merged

Add utility for zMid#453
cbegeman merged 5 commits intoE3SM-Project:mainfrom
cbegeman:add-zmid-utility

Conversation

@cbegeman
Copy link
Copy Markdown
Collaborator

@cbegeman cbegeman commented Jan 27, 2026

Compute zMid and zInterface from ssh and layerThickness and check whether it matches bottomDepth

Note: we may want to change this to computing from bottomDepth and layerThickness as is done in MPAS-Ocean but I found this way more useful for debugging Omega.

We may also want to return zInterface in the future.

Checklist

  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

Comment thread polaris/ocean/vertical/diagnostics.py Outdated
Comment thread polaris/ocean/vertical/diagnostics.py Outdated
@cbegeman
Copy link
Copy Markdown
Collaborator Author

Testing

Testing has been done in the context of #435 on chrys, intel, openmpi with omega

@cbegeman
Copy link
Copy Markdown
Collaborator Author

@xylar Should be ready now if you want to rereview

Copy link
Copy Markdown
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few comments to consider.

Comment thread polaris/ocean/vertical/diagnostics.py Outdated
Comment thread polaris/ocean/vertical/diagnostics.py Outdated
Copy link
Copy Markdown
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbegeman, yes this looks good to me! Thanks for making those changes.

@cbegeman cbegeman merged commit 9b29e61 into E3SM-Project:main Jan 30, 2026
7 checks passed
@cbegeman cbegeman deleted the add-zmid-utility branch January 30, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants