Add omega support for time-variant sphere transport flows#500
Draft
cbegeman wants to merge 27 commits intoE3SM-Project:mainfrom
Draft
Add omega support for time-variant sphere transport flows#500cbegeman wants to merge 27 commits intoE3SM-Project:mainfrom
cbegeman wants to merge 27 commits intoE3SM-Project:mainfrom
Conversation
cbegeman
added
the
Omega PR required
…sphere_transport viz
This update brings in: * E3SM-Project/Omega#362 * E3SM-Project/Omega#359 * E3SM-Project/Omega#374
Revise the vector reconstruction design doc to address review feedback. - move the proposed implementation from polaris/mpas to polaris/mesh - clarify that this PR is limited to Polaris design and mesh-field writing - state that MPAS-Ocean and Omega support will follow in later PRs - clarify that zonal/meridional outputs are tangential and exclude the radial part - explain that tangential reconstruction is produced in Cartesian form first - clarify why the in-memory cache and mesh-field export are separate steps - replace a few software-oriented phrases with plainer wording - tighten testing plans for culled meshes and nonzero radial contributions - narrow contributor/date updates to sections with substantive review-driven edits
These are designed to keep these tools from straying too far from the Polaris coding style and to make the easier for developers to use without later fighting with pre-commit.
…o init for rotation_2d
…phere_transport tests
cbegeman
force-pushed
the
add-omega-support-time-variant-sphere-transport
branch
from
ce9a8f4 to
f2b323b
Compare
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required Omega PR: E3SM-Project/Omega#365
Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes