Skip to content

Update to PCD 0.1.0#505

Merged
xylar merged 2 commits intoE3SM-Project:mainfrom
xylar:update-pcd-to-0.1.0
Mar 30, 2026
Merged

Update to PCD 0.1.0#505
xylar merged 2 commits intoE3SM-Project:mainfrom
xylar:update-pcd-to-0.1.0

Conversation

@xylar
Copy link
Copy Markdown
Collaborator

@xylar xylar commented Mar 22, 2026 •
edited
Loading

This brings in Omega PRs:

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar self-assigned this Mar 22, 2026
@xylar xylar added framework Changes relating to the polaris framework as opposed to individual tests or analysis Omega PR required The polaris changes won't work with the current Omega submodule and require an update labels Mar 22, 2026
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 22, 2026 •
edited
Loading

Testing

Tested in conjunction with E3SM-Project/Omega#371 on Chrysalis with Intel. The omega_pr suite passes with the current Omega submodule as a baseline.

The omega_pr suite also passes with E3SM-Project/Omega#372, which should also be included in the submodule update here.

This was referenced Mar 22, 2026
Merged
Merged
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 26, 2026

With E3SM-Project/Omega#371 and E3SM-Project/Omega#372 merged, I need to do a submodule update here and re-test.

@xylar xylar force-pushed the update-pcd-to-0.1.0 branch from 25a99a4 to 66446b8 Compare March 26, 2026 21:05
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 27, 2026 •
edited
Loading

I think there are too many Omega updates and I need a separate PR -- #508

@xylar xylar force-pushed the update-pcd-to-0.1.0 branch from 66446b8 to 3fd5666 Compare March 27, 2026 09:19
@xylar xylar marked this pull request as ready for review March 27, 2026 09:20
@xylar xylar added Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished and removed Omega PR required The polaris changes won't work with the current Omega submodule and require an update labels Mar 27, 2026
@xylar xylar requested a review from katsmith133 March 27, 2026 12:38
@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 27, 2026

@katsmith133, I've tested this again after updating the Omega submodule in this branch. Would you be willing to give this a quick review by inspection?

@xylar xylar force-pushed the update-pcd-to-0.1.0 branch from 3fd5666 to f074613 Compare March 27, 2026 20:53
@xylar xylar mentioned this pull request Mar 27, 2026
Merged
1 task
katsmith133
katsmith133 approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@katsmith133 katsmith133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by inspection. Units and values agree with that in the PCD of E3SM (and thus what is in Omega too).

Let me know if you want me to do testing.

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Mar 30, 2026

Thanks @katsmith133.

@xylar xylar merged commit 771152d into E3SM-Project:main Mar 30, 2026
6 checks passed
@xylar xylar deleted the update-pcd-to-0.1.0 branch March 30, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katsmith133 katsmith133 katsmith133 approved these changes

Assignees

@xylar xylar

Labels

framework Changes relating to the polaris framework as opposed to individual tests or analysis Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xylar @katsmith133