Add a design document for the unified base mesh#521
Open
xylar wants to merge 9 commits intoE3SM-Project:mainfrom
Open
Add a design document for the unified base mesh#521xylar wants to merge 9 commits intoE3SM-Project:mainfrom
xylar wants to merge 9 commits intoE3SM-Project:mainfrom
Conversation
xylar
added
documentation
Collaborator
Author
|
This is a draft, but feel free to comment and give feedback. |
1 task
Collaborator
Author
|
I'm going to fold #522 into this branch. It is too much effort to keep the designs separate. |
This mesh is intended to work for the E3SM land, river, ocean and sea-ice components
Also, clarify a bit what the scope of build_sizing_field actually is.
xylar
force-pushed
the
add-unified-base-mesh-design-doc
branch
from
b25da60 to
2a8cc8f
Compare
Here, we add more considerations about lat-lon resolution that is sufficient for defining a reasonable coastline. We also add a flood fill to make sure the ocean is contiguous. Finally, we add 3 different masks for the coastline in Antarctica: calving front, grounding line or zero bedrock elevation (for wetting-and-drying).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mesh is intended to work for the E3SM land, river, ocean and sea-ice components.
This PR also adds design docs for 3 shared steps related to the unified base mesh, tentatively named :
prepare_coastlineprepare_river_networkbuild_sizing_fieldChecklist