Open
Conversation
okazy
approved these changes
Jun 24, 2020
Contributor
okazy
left a comment
There was a problem hiding this comment.
ありがとうございます。修正内容問題ないかと思います。
Contributor
|
落ちていたテストは今回の修正と関係なさそうでしたので再実行しました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
以下を参考にコメントを作成してください。
概要(Overview・Refs Issue)
プラグイン, テンプレートアップロード時、詳細なエラーメッセージが黙殺されており、お問い合わせを受けても、すぐに解凍できない
方針(Policy)
Exception::getMessage()の内容を出力する実装に関する補足(Appendix)
テスト(Test)
Exception をスローさせて、エラーメッセージが表示されるのを確認