PyTorch Versions of TC1 and P1B2 Benchmarks#96
Open
knangia04 wants to merge 2 commits intoECP-CANDLE:developfrom
Open
PyTorch Versions of TC1 and P1B2 Benchmarks#96knangia04 wants to merge 2 commits intoECP-CANDLE:developfrom
knangia04 wants to merge 2 commits intoECP-CANDLE:developfrom
Conversation
knangia04
commented
Aug 23, 2021
knangia04
commented
- Code is generic and handles the neural network model as defined in the model_pytorch.txt file (similar to the TensorFlow/Keras version).
- baseline_pytorch.py is the main function of the benchmark.
- Updated pytorch_utils.py to add additional functionality.
- torch_deps folder consists of dependencies that are required for the PyTorch benchmark, including a model class, dataset DataLoader class, classification network, training, validation, and test functions, and weight initialization.
* baseline_pytorch.py is the main function of the benchmark. * Updated pytorch_utils.py to add additional functionality. * torch_deps folder consists of dependencies that are required for the benchmark to function correctly, including the model, dataset, classification network, training, validation, and test functions, and weight initialization.
hyoo
reviewed
Aug 23, 2021
hyoo
left a comment
hyoo
left a comment
There was a problem hiding this comment.
This is good work. I suggest a few changes to keep the code consistent and maintainable. Will add a few more as we move on.
Contributor
|
How does this commit relate to #95 which seems to be similar (at least in name) |
1. Updated to use the original default_model txt file. 2. Updated common/pytorch_utils.py based on the the local pytorch_utils.py and deleted the local versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.