Conversation
instead of just the first one installed in the Path. This is to avoid picking the version (v2) installed by recent docker in the path and is not compatible yet
gchazot
force-pushed
the
use-python-docker-compose
branch
from
90dbd57 to
bd96529
Compare
gchazot
force-pushed
the
use-python-docker-compose
branch
from
715f073 to
59630df
Compare
DilaraOflaz
approved these changes
Mar 12, 2024
Author
|
Thanks @DilaraOflaz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR
When
ktdis invoked, it used to calldocker-composecommand from the current PATH. This causes conflict with newer versions of docker which install their own version ofdocker-composein the PATH. The version from Docker is using the "Compose V2" standard which is not yet supported bykubetools(WIP: #163).This change makes sure that we call the "python" version of
docker-compose. By using the current "executable", i.e. the current interpreter which is runningktd, and callingcomposeas a Python module, we maximise the chances that the version of docker-compose used is the Python one that was installed as a dependency ofkubetools.This creates the opportunity to install
kubetoolsin its own separate virtualenv and run it by linkingkubetoolsandktdexecutables into the PATH. In a similar fashion, this should allow the support ofpipxas an installation method.