Skip to content

Conversation

@yixin98
Copy link

@yixin98 yixin98 commented Dec 11, 2025

Description

Updates to function vpdefil: use different functions to calculate saturation vapor pressure for ice VS liquid. The old scripts always use ice saturation vapor pressure, and this will introduce errors in the calculation of VPD.

Types of changes

  • Hot fix (emergential bug fix to make ED2 run again)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (fix or feature that would cause existing functionality to change)

Testing :

  • All new and existing tests passed.

…ions to calculate saturation vapor pressure for ice VS liquid. The old scripts always use ice saturation vapor pressure.
Copy link
Contributor

@mpaiao mpaiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @yixin98!

@mpaiao mpaiao merged commit c0a9b68 into EDmodel:master Dec 12, 2025
4 of 6 checks passed
@xiangtaoxu
Copy link
Contributor

Thanks, Yixin. @mpaiao do we know how old is this bug? I wonder how much it might have amplified midday suppression in previous simulations...

@mpaiao
Copy link
Contributor

mpaiao commented Dec 12, 2025

It is probably very old @xiangtaoxu, but as far as I remember, vpd is a purely diagnostic variable in ED2. The only reason I added it was because we cannot back calculate average VPD from the other averaged variables, as the relation between VPD and other variables is very non-linear.

@xiangtaoxu
Copy link
Contributor

Ah. That's right. Good to know!

@mpaiao mpaiao mentioned this pull request Dec 15, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants