Skip to content

Conversation

@bedroge
Copy link
Collaborator

@bedroge bedroge commented Sep 16, 2025

Not tested yet. Partially solves #244, but doesn't show yet which namespace successfully verified the signature. That's a bit more tricky, can be done in a follow-up PR.

@bedroge bedroge added the Automated ingestion Issues related to the automated ingestion workflow label Sep 16, 2025
@bedroge bedroge requested a review from trz42 September 16, 2025 13:32
@bedroge
Copy link
Collaborator Author

bedroge commented Sep 16, 2025

Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (only a very minor suggestion). I guess the additional payload_verified is added to the config setting
task_summary_payload_template.

I noted that we have no example configuration file (similar to automated_ingestion.cfg.example) and also the README.md is outdated. I think these could be handled in a follow-up PR too.

Co-authored-by: Thomas Röblitz <trz42@users.noreply.github.com>
@bedroge
Copy link
Collaborator Author

bedroge commented Sep 16, 2025

Looks good to me (only a very minor suggestion). I guess the additional payload_verified is added to the config setting task_summary_payload_template.

I noted that we have no example configuration file (similar to automated_ingestion.cfg.example) and also the README.md is outdated. I think these could be handled in a follow-up PR too.

I've opened an issue for the example configuration file: #251.

The README is more or less mentioned in #245.

Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and new issue. Looks good to me.

@trz42 trz42 merged commit 4c8eea7 into EESSI:main Sep 18, 2025
23 checks passed
@bedroge bedroge deleted the autoingest_sig_verification_icon branch September 18, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automated ingestion Issues related to the automated ingestion workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants