-
Notifications
You must be signed in to change notification settings - Fork 66
Make sure that the TMPDIR is used as STORAGE if it is set #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that the TMPDIR is used as STORAGE if it is set #911
Conversation
|
Instance
|
|
Instance
|
|
Instance
|
|
Instance
|
|
Instance
|
|
Instance
|
trz42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should limit this (bind-mounting $TMPDIR) to cases where it is needed.
The setting of $STORAGE in bot/build.sh is ok, the bind-mount part should be moved to eessi_container.sh
…e TMP_IN_CONTAINER doesn't already contain that prefix
|
Ok, so that worked #912 (comment) , I'm happy with this. I checked using that there weren't any |
trz42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
This is one of three pieces split off from #903
Together with EESSI/eessi-bot-software-layer#299 this makes sure that
TMPDIRis set tolocal_tmpas configured inapp.cfg, and then with this PR we ensure that thatTMPDIRis actually used everywhere if it is set. We also bind-mount it in the container, so that if any subsequent script calls amktempin the container, that is able to just created a dir within the mounted TMPDIR.