Optimized PairingHeap.Extract#1
Open
Dancpaz wants to merge 1 commit intoEGrun:masterfrom
Dancpaz:optimize-extract
Open
Optimized PairingHeap.Extract#1Dancpaz wants to merge 1 commit intoEGrun:masterfrom Dancpaz:optimize-extract
Dancpaz wants to merge 1 commit intoEGrun:masterfrom
Dancpaz:optimize-extract
Conversation
…ime, and reducing allocation.
Author
|
Canceled due to a potential bug. Will fix and resubmit later. |
Author
|
Confirmed that the potential bug I was worried about did not actually exist. Reopening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized PairingHeap.Extract to the following effect:
Benchmarked these changes with BenchmarkDotNet in .NET 6 in a different project:
Original Method: 261.6 us
Updated Method: 184.1 us
The benchmark consisted of inserting 1,000 random numbers, then extracting them all.
All tests pass.