Add exception when trying to filter data with NaN-values#370
Merged
Add exception when trying to filter data with NaN-values#370
Conversation
JulietteFrancovich
approved these changes
Aug 11, 2025
psomhorst
force-pushed
the
fix_filter_nan_values
branch
from
51d4e36 to
a75680a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Butterworth filters can't handle data with NaN-values. Currently, if you pass data with NaN-values to
apply_filter(...), it will silently return an array with all-NaN-data. This is difficult to debug.This PR adds a check that raises an exception when the data to be filtered contains any NaN values. It also tips the user on how to fix the problem.