-
Notifications
You must be signed in to change notification settings - Fork 42
[Buffers][NOT COMPLETE] Add latency and occupancy balancing constraints. #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ziadomalik
wants to merge
76
commits into
main
Choose a base branch
from
feat/ziad/milp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also it's more modular now, take the logic out of the constructor, and a data flow graph describes a single thing, not an array of things
…es with hacky stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: 17.01.25
This PR is not mergeable yet, in my goal to latency and occupancy balance
fir.c, I only got:~3000cycles normally~2000cycles with this hackContext on the hack that makes me achieve
~2000 cyclesMultiply latency seems to be 5, so accordingly the LP places 5 DV buffers.
When I did the manual placement I used 6 DV, (I think we debugged this together).
So the way I remember this, for
II=1with a 5-cycle component, we need 6 DV Buffers because:Is this the correct reasoning? If yes, with what constraint does the paper account for this? Or is my mistake maybe somewhere else.
Another Problem with Section 5, Equation 11:
The paper says:
When enabled, the solver concentrates occupancy on the wrong channels.
What we want is:
fork5→ N=6,fork3→ N=6 (matching L values)Got:
mux1→ N=5,fork5→ N=4 (4 FIFO + 1 DV instead of 6 DV)The solver satisfies the path sum cheaply by putting occupancy on narrow channels (mux output) instead of where LP1 added latency (fork outputs). How should Equation 11 be implemented correctly? Is there a constraint I am missing that's tying occupancy to specific channels? For now I just disabled it.
Debug Output: